Skip to content

fix: issues from audit#139

Merged
leruaa merged 5 commits intomainfrom
aurelien/gro2-658-fix-potential-issues-in-rsp
Jun 17, 2025
Merged

fix: issues from audit#139
leruaa merged 5 commits intomainfrom
aurelien/gro2-658-fix-potential-issues-in-rsp

Conversation

@leruaa
Copy link
Collaborator

@leruaa leruaa commented Jun 16, 2025 •
edited
Loading

In this PR:

  • Validate headers against its parent
  • Fix Optimism base fee params
  • Validate block body against its header
  • Small refactoring in NPT

@github-actions
Copy link

github-actions bot commented Jun 16, 2025

Block 20600000 Base Branch Current PR Diff Diff (%)
Total Cycle Count 252,147,644 252,196,549 48,905 0.02
Inputs deserialization 52,326,019 52,323,229 -2,790 -0.01
Initialize Witness DB 52,161,434 52,149,047 -12,387 -0.02
Recover Senders 9,824,284 9,824,231 -53 -0.00
Header Validation 3,827 21,435 17,608 460.10
Block Execution 105,969,161 105,997,639 28,478 0.03
Block Validation 3,742,727 3,742,732 5 0.00
Accrue Logs Bloom 1,720,789 1,720,789 0 -0.00
State Root Computation 23,954,453 23,948,113 -6,340 -0.03
Syscall Count 211,175 211,185 10 0.00
Prover Gas 367,882,260 367,639,870 -242,390 -0.07

@github-actions
Copy link

github-actions bot commented Jun 16, 2025

Block 20600000 Base Branch Current PR Diff Diff (%)
Total Cycle Count 252,142,966 252,198,213 55,247 0.02
Inputs deserialization 52,324,275 52,325,136 861 0.00
Initialize Witness DB 52,157,938 52,148,829 -9,109 -0.02
Recover Senders 9,824,284 9,824,231 -53 -0.00
Header Validation 3,827 21,435 17,608 460.10
Block Execution 105,969,711 105,997,639 27,928 0.03
Block Validation 3,742,727 3,742,732 5 0.00
Accrue Logs Bloom 1,720,789 1,720,789 0 -0.00
State Root Computation 23,954,467 23,948,087 -6,380 -0.03
Syscall Count 211,175 211,185 10 0.00
Prover Gas 368,439,489 367,744,863 -694,626 -0.19

@github-actions
Copy link

github-actions bot commented Jun 16, 2025

Block 20600000 Base Branch Current PR Diff Diff (%)
Total Cycle Count 252,151,912 254,387,933 2,236,021 0.89
Inputs deserialization 52,328,465 53,058,097 729,632 1.39
Initialize Witness DB 52,161,098 52,156,839 -4,259 -0.01
Recover Senders 9,824,284 9,824,231 -53 -0.00
Header Validation 3,827 1,467,175 1,463,348 38237.47
Block Execution 105,971,281 106,002,471 31,190 0.03
Block Validation 3,742,727 3,742,732 5 0.00
Accrue Logs Bloom 1,720,789 1,720,789 0 -0.00
State Root Computation 23,954,493 23,946,277 -8,216 -0.03
Syscall Count 211,175 211,819 644 0.30
Prover Gas 368,439,489 371,940,410 3,500,921 0.95

@leruaa leruaa merged commit 1dd3021 into main Jun 17, 2025
5 of 6 checks passed
eason1981 added a commit to brevis-network/rsp that referenced this pull request Sep 11, 2025
@eason1981 @nhtyy @leruaa
fix: sync from upstream and enable debug_executionWitness as defaul…
261dee3 
…t RPC (#2)

* chore: bump SP1 deps to v5 (succinctlabs#133)

* wip: cuda prover builder missing moongate endpoint

* fix: with_moongate_endpoint()

---------

Co-authored-by: leruaa <aurelien.catinon@gmail.com>

* fix: allow to sync MptNode to another thread (succinctlabs#134)

* fix: allow to send MptNode to another thread

* fix: don't share cached reference accross clones

* feat: hash genesis (succinctlabs#138)

* feat: impl Hash for Genesis

* feat: handle custom OP chains

* fix: better handle errors

* fix: rename Error

* fix: infinite loop

* fix: issues from audit (succinctlabs#139)

* fix: validate headers against its parent

* fix: Optimism base fee params

* fix: validate body against header

* fix: log bloon verification is done in validate_block_post_execution

* nit: reuse reference()

* fix: use OpChainSpec::from_genesis (succinctlabs#141)

* fix: allow to serialize ChainConfig with bincode (succinctlabs#142)

* fix: allow to serialize ChainConfig with bincode

* fix: add OP Sepolia endpoint in CI

* nit: raw_value feature not needed

* chore: bump Reth to 1.5.0 (succinctlabs#136)

* chore: bump Reth to 1.4.8

* chore: bump SP1 to v5.0.5

* fix: skip checks for Linea

* fix: pin SP1 in containers

* chore: bump alloy-serde

* chore: bump alloy to 1.0.12

* chore: bump Reth to 1.5.0

* chore: update lock files

* fix: remove unused state_requests

* chore: update sha2 patch to v0.10.9

* fix: use validate_body_against_header_op on OP chains (succinctlabs#145)

* chore: bump SP1 to v5.1 (succinctlabs#148)

* feat: debug_executionWitness support (succinctlabs#147)

* feat: refactor RpcDb to prepare another impl with ExecutionWitness

* feat: add a feature to fetch the state using execution witness

* fix: remaining todos

* feat: enable `execution-witness` feature on eth proofs

* revert: enable `execution-witness` feature on eth proofs

This reverts commit fdfb12c.

* fix: order ancestor headers (succinctlabs#149)

* chore: bump reth to 1.6.0 (succinctlabs#151)

* chore: bump Reth to 1..6.0

* fix: clippy

* fix: clippy again

* enable `execution-witness` as default RPC API

* clean

* update reth and add a test script

* disable `execution-witness` in eth-proofs bin

* add more test blocks

* delete ci

* delete useless script

* fix `cargo install`

---------

Co-authored-by: N <n@push0.dev>
Co-authored-by: leruaa <aurelien.catinon@gmail.com>
Co-authored-by: Aurélien <3535019+leruaa@users.noreply.github.com>
Co-authored-by: eason <eason@brevis.network>
wraitii added a commit to hyli-org/rsp that referenced this pull request Oct 22, 2025
@wraitii
Remove log_bloom form CSV report
c0bd1db 
Fixes an error in 1dd3021 / succinctlabs#139, where log_bloom printing was removed but the header columns wasn't.
@wraitii wraitii mentioned this pull request Oct 22, 2025
Merged
leruaa pushed a commit that referenced this pull request Oct 23, 2025
@wraitii
fix: remove log_bloom form CSV report (#158)
c14b400 
Fixes an error in 1dd3021 / #139, where log_bloom printing was removed but the header columns wasn't.
eason1981 added a commit to brevis-network/rsp that referenced this pull request Dec 1, 2025
@eason1981 @nhtyy
@leruaa @dmitry123 @koxu1996 @wraitii @fakedev9999 @hecmas
feat: sync upstream and update for eth Fusaka upgrade (#5)
a005ee4 
* chore: bump SP1 deps to v5 (succinctlabs#133)

* wip: cuda prover builder missing moongate endpoint

* fix: with_moongate_endpoint()

---------

Co-authored-by: leruaa <aurelien.catinon@gmail.com>

* fix: allow to sync MptNode to another thread (succinctlabs#134)

* fix: allow to send MptNode to another thread

* fix: don't share cached reference accross clones

* feat: hash genesis (succinctlabs#138)

* feat: impl Hash for Genesis

* feat: handle custom OP chains

* fix: better handle errors

* fix: rename Error

* fix: infinite loop

* fix: issues from audit (succinctlabs#139)

* fix: validate headers against its parent

* fix: Optimism base fee params

* fix: validate body against header

* fix: log bloon verification is done in validate_block_post_execution

* nit: reuse reference()

* fix: use OpChainSpec::from_genesis (succinctlabs#141)

* fix: allow to serialize ChainConfig with bincode (succinctlabs#142)

* fix: allow to serialize ChainConfig with bincode

* fix: add OP Sepolia endpoint in CI

* nit: raw_value feature not needed

* chore: bump Reth to 1.5.0 (succinctlabs#136)

* chore: bump Reth to 1.4.8

* chore: bump SP1 to v5.0.5

* fix: skip checks for Linea

* fix: pin SP1 in containers

* chore: bump alloy-serde

* chore: bump alloy to 1.0.12

* chore: bump Reth to 1.5.0

* chore: update lock files

* fix: remove unused state_requests

* chore: update sha2 patch to v0.10.9

* fix: use validate_body_against_header_op on OP chains (succinctlabs#145)

* chore: bump SP1 to v5.1 (succinctlabs#148)

* feat: debug_executionWitness support (succinctlabs#147)

* feat: refactor RpcDb to prepare another impl with ExecutionWitness

* feat: add a feature to fetch the state using execution witness

* fix: remaining todos

* feat: enable `execution-witness` feature on eth proofs

* revert: enable `execution-witness` feature on eth proofs

This reverts commit fdfb12c.

* fix: order ancestor headers (succinctlabs#149)

* chore: bump reth to 1.6.0 (succinctlabs#151)

* chore: bump Reth to 1..6.0

* fix: clippy

* fix: clippy again

* chore: add veridise audit report for Fluent STF (succinctlabs#152)

* chore: bump Reth to v1.7.0 (succinctlabs#153)

* feat: add holesky (succinctlabs#154)

* feat: add holesky

* feat: add holesky()

* chore: update RSP cache

* fix: add holesky RPC

* chore: bump Reth to v1.8.1 (succinctlabs#155)

* chore: bump Reth to v1.8.2 (succinctlabs#157)

* feat: readable Debug formatting for MPT nodes (succinctlabs#156)

* Add full cover example for `EthereumState` debug printing.

* Implement custom debug print for MPT types.

* Fix clippy errors.

* fix: remove log_bloom form CSV report (succinctlabs#158)

Fixes an error in 1dd3021 / succinctlabs#139, where log_bloom printing was removed but the header columns wasn't.

* fix: add BPO blob schedule on sepolia (succinctlabs#159)

* chore: bump Reth to v1.8.3

* feat: update blob params (succinctlabs#161)

* chore: bump reth to v1.9.0

* chore: remove c-kzg feature flag

* feat: use a custom Crypto to replace kzg-rs

* feat: use alloy-genesis serde_bincode_compat for ChainConfig

* test: check blob schedule in bincode roundtrip

* chore: bump Reth to v1.9.1 (succinctlabs#164)

* fix: normalize the code hash whaen the RPC badly returns `0x000...000` for for non-existing EOAs

* feat: add new precompiles (succinctlabs#166)

* check kzg patch

* remove useless dependency `alloy-serde`

* add pico-processor bin (#6)

Co-authored-by: eason <eason@brevis.network>

---------

Co-authored-by: N <n@push0.dev>
Co-authored-by: leruaa <aurelien.catinon@gmail.com>
Co-authored-by: Aurélien <3535019+leruaa@users.noreply.github.com>
Co-authored-by: Dmitry Savonin <3367605+dmitry123@users.noreply.github.com>
Co-authored-by: koxu1996 <andrzej1_1@o2.pl>
Co-authored-by: Lancelot de Ferrière <wraitii@users.noreply.github.com>
Co-authored-by: fakedev9999 <taehoon@succinct.xyz>
Co-authored-by: Héctor Masip Ardevol <68732820+hecmas@users.noreply.github.com>
Co-authored-by: eason <eason@brevis.network>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nhtyy nhtyy nhtyy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@leruaa @nhtyy