use fully qualified URLs for images in atom feed #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabobalis
reviewed
Apr 11, 2023
nabobalis
reviewed
Apr 11, 2023
Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
nabobalis
approved these changes
Apr 11, 2023
Member
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Fixes #19
Some RSS readers might render the atom feed locally without any further requests to the remote website. This breaks images in the feed as they are sourced from relative links as discussed in issue #19.
This PR fixes this issue by always using a complete URL based on
blog_baseurlas source of images in the HTML contents of the feed. Blogs without abaseurlwill continue to use relative paths in their feeds.