Adds shape property to NDCube#684
Merged
DanRyanIrish merged 39 commits intosunpy:mainfrom Apr 24, 2024
Merged
Conversation
Depricates `dimensions` property
CyclingNinja
force-pushed
the
remove_dimension
branch
from
bd06799 to
32b58c4
Compare
DanRyanIrish
requested changes
Apr 23, 2024
Member
DanRyanIrish
left a comment
DanRyanIrish
left a comment
There was a problem hiding this comment.
Comments regarding NDCubeSequence: As well as request changes, make NDCubeSequence.dimensions do this:
def dimensions(self):
return tuple([d * u.pix for d in self._shape])Also, create a .shape property that just returns self._shape.
It's possible this may cause breaks elsewhere...
Co-authored-by: DanRyanIrish <ryand5@tcd.ie>
Co-authored-by: DanRyanIrish <ryand5@tcd.ie>
Co-authored-by: DanRyanIrish <ryand5@tcd.ie>
DanRyanIrish
requested changes
Apr 24, 2024
nabobalis
reviewed
Apr 24, 2024
nabobalis
reviewed
Apr 24, 2024
nabobalis
reviewed
Apr 24, 2024
nabobalis
reviewed
Apr 24, 2024
Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
Co-authored-by: DanRyanIrish <ryand5@tcd.ie>
Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
nabobalis
reviewed
Apr 24, 2024
nabobalis
reviewed
Apr 24, 2024
nabobalis
reviewed
Apr 24, 2024
nabobalis
reviewed
Apr 24, 2024
nabobalis
reviewed
Apr 24, 2024
CyclingNinja
force-pushed
the
remove_dimension
branch
from
8a9d566 to
c8676c2
Compare
Depricates `dimensions` property
Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
Co-authored-by: DanRyanIrish <ryand5@tcd.ie>
Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
nabobalis
force-pushed
the
remove_dimension
branch
from
c8676c2 to
69d2cf1
Compare
…o remove_dimension
Co-authored-by: DanRyanIrish <ryand5@tcd.ie>
DanRyanIrish
requested changes
Apr 24, 2024
Co-authored-by: DanRyanIrish <ryand5@tcd.ie>
DanRyanIrish
approved these changes
Apr 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecates the
dimensionsproperty