-
-
Notifications
You must be signed in to change notification settings - Fork 55
Support Ellipsis in NDCube.__getitem__ #818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
900ae1f
handling ellipsis
Diya910 8f9da59
test cases added
Diya910 e1971b6
changelog added
Diya910 7ac9228
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 0af338c
Updated test file by using pre defined fixture
Diya910 acd2a92
Update test_ndslicing.py
Diya910 8f51209
Merge branch 'main' into ellipsis
Diya910 15a6c96
Merge branch 'main' into ellipsis
DanRyanIrish 949dfb1
Apply suggestions from code review
DanRyanIrish f6dc63e
Fix missing comma
DanRyanIrish de35444
Add missin import
DanRyanIrish d3c138d
Add missing args to test.
DanRyanIrish c669ab8
Update ndcube/mixins/tests/test_ndslicing.py
DanRyanIrish 2546739
Update ndcube/mixins/tests/test_ndslicing.py
DanRyanIrish cc5882a
Fix isort
DanRyanIrish File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Added Ellipsis functionality to ndcube.mixins.ndslicing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import numpy as np | ||
| import pytest | ||
|
DanRyanIrish marked this conversation as resolved.
|
||
|
|
||
| from astropy.wcs import WCS | ||
|
|
||
| from ndcube import NDCube | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def sample_ndcube(): | ||
| data = np.random.rand(4, 4, 4) | ||
| wcs = WCS(naxis=3) | ||
| return NDCube(data, wcs) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I thought there were other fixtures defined elsewhere which can be used for the test below.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. let me see |
||
|
|
||
| def test_ellipsis_usage(sample_ndcube): | ||
| sliced_cube = sample_ndcube[..., 1] | ||
| assert sliced_cube.data.shape == (4, 4) | ||
|
|
||
| with pytest.raises(IndexError, match="An index can only have a single ellipsis"): | ||
| sample_ndcube[..., ..., 1] | ||
|
DanRyanIrish marked this conversation as resolved.
Outdated
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.