-
-
Notifications
You must be signed in to change notification settings - Fork 55
Enable multiplying NDCube and NDData #840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
628b362
Create placeholder for the ndcube.multiply() method.
PCJY 7742ec0
Adding an ndcube._arithmetic method to handle both add and multiply.
PCJY 847035e
Merge branch 'main' into mul
DanRyanIrish 74b9f47
Merge branch 'mul' of https://github.com/PCJY/ndcube into mul
PCJY 047ea58
Added one new argument into the ndcube._arithmetic() method
PCJY 9b8bff7
Update ndcube/ndcube.py
PCJY 87d8da3
Update ndcube/ndcube.py
PCJY 6ad57b8
Changed some arguments and method structures.
PCJY 3660355
Merge branch 'mul' of https://github.com/PCJY/ndcube into mul
PCJY 0f30930
Changing the ndcube._arithmetic_operate_with_nddata() method.
PCJY fb9e59e
Handling mask in arithmetic operation moved to its own private method.
PCJY d0d47e6
Added the multiply support to the _arithmetic_operate_with_nddata().
PCJY 1b780b8
Changed the multiply method.
PCJY 99ece40
Added Changelog.
PCJY 32247b6
Merge branch 'main' of https://github.com/sunpy/ndcube into mul
PCJY fd1f303
Update ndcube/ndcube.py
PCJY 41a4053
Update ndcube/ndcube.py
PCJY 945fb42
The add and multiply methods are now called by the __add__ and __mul_…
PCJY b1f2861
Merge branch 'main' of https://github.com/sunpy/ndcube into mul
PCJY e452685
Deleted the test for raising an error pointing users to ndcube.add().
PCJY bca3abe
Deleted the handle_mask argument. Keep the dunder methods.
PCJY bdcd7b7
Changed tests.
PCJY 460a450
Fixing tests.
PCJY 8c0edab
Fixed tests.
PCJY 0d714dc
Merge branch 'main' of https://github.com/sunpy/ndcube into mul
PCJY d035ef7
Update ndcube/tests/test_ndcube.py
PCJY 573c6a2
Update ndcube/tests/test_ndcube.py
PCJY 0cf3d94
Changed the place of ndcube parametrize's definition.
PCJY cbcf15d
Deleted previously added unnecessary fixtures.
PCJY File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.