feat: allow for multiple metadata filters on list fields#179
Merged
Conversation
Contributor
Author
|
Can be merged as far as I can tell @emilradix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors metadata filtering so search and delete consistently support multi-value filters with clear semantics, and updates self-query so it can select multiple filters per field.
What Changed
Metadata filtering implementation
src/raglite/_metadata_filter.pybuild_metadata_filter_condition(...)for SQLAlchemy query conditions.build_metadata_filter_sql(...)for raw SQL query fragments + params.src/raglite/_search.pyvector_search()now uses shared condition builder.keyword_search()now uses shared SQL builder for PostgreSQL and DuckDB.src/raglite/_delete.py_get_documents_with_metadata()now builds conditions via shared helper.Self-query improvements
src/raglite/_search.pyself-query prompt and mapping logic so a single metadata field can return multiple matched values.Tests
tests/test_search.py_self_querytest to verify multiple values per field are preserved.tests/test_delete.pyDocs
README.md