Skip to content

Enable post-processing in VR #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmarcos merged 5 commits into from
Jan 31, 2025
Merged

Enable post-processing in VR #20

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e49ce01
Update WebXRManager.js
enzofrancescaHM Jan 23, 2025
02e260d
Update WebGLRenderer.js
enzofrancescaHM Jan 23, 2025
0378b1a
Update WebGLRenderer.js
enzofrancescaHM Jan 26, 2025
75c550c
Update WebXRManager.js
enzofrancescaHM Jan 26, 2025
6ed1447
Update WebGLRenderer.js
enzofrancescaHM Jan 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/renderers/WebGLRenderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2335,6 +2335,15 @@ class WebGLRenderer {
const _scratchFrameBuffer = _gl.createFramebuffer();
this.setRenderTarget = function ( renderTarget, activeCubeFace = 0, activeMipmapLevel = 0 ) {



Comment thread
enzofrancescaHM marked this conversation as resolved.
Outdated
// Render to base layer instead of canvas in WebXR
if ( renderTarget === null && this.xr.isPresenting ) {

renderTarget = this.xr._getRenderTarget();

}

_currentRenderTarget = renderTarget;
_currentActiveCubeFace = activeCubeFace;
_currentActiveMipmapLevel = activeMipmapLevel;
Expand Down
16 changes: 16 additions & 0 deletions src/renderers/webxr/WebXRManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,10 @@ class WebXRManager extends EventDispatcher {
session = null;
newRenderTarget = null;


renderer.setPixelRatio( currentPixelRatio );
renderer.setSize( currentSize.width, currentSize.height, false );

Comment thread
enzofrancescaHM marked this conversation as resolved.
Outdated
//

animation.stop();
Expand Down Expand Up @@ -248,6 +252,12 @@ class WebXRManager extends EventDispatcher {

};

this._getRenderTarget = function () {
Comment thread
enzofrancescaHM marked this conversation as resolved.
Outdated

return newRenderTarget;

};

this.getFrame = function () {

return xrFrame;
Expand Down Expand Up @@ -302,6 +312,8 @@ class WebXRManager extends EventDispatcher {

session.updateRenderState( { baseLayer: glBaseLayer } );



Comment thread
enzofrancescaHM marked this conversation as resolved.
Outdated
renderer.setPixelRatio( 1 );
renderer.setSize( glBaseLayer.framebufferWidth, glBaseLayer.framebufferHeight, false );

Expand Down Expand Up @@ -389,6 +401,10 @@ class WebXRManager extends EventDispatcher {
customReferenceSpace = null;
referenceSpace = await session.requestReferenceSpace( referenceSpaceType );

currentPixelRatio = renderer.getPixelRatio();
renderer.getSize( currentSize );


Comment thread
enzofrancescaHM marked this conversation as resolved.
Outdated
animation.setContext( session );
animation.start();

Expand Down