Comparison Tool 5.5: Filtering out Stable Nuclides of Irradiated Element#195
Draft
eitan-weinstein wants to merge 24 commits intosvalinn:mainfrom
Draft
Comparison Tool 5.5: Filtering out Stable Nuclides of Irradiated Element#195eitan-weinstein wants to merge 24 commits intosvalinn:mainfrom
eitan-weinstein wants to merge 24 commits intosvalinn:mainfrom
Conversation
Member
|
I'm not thrilled about hard-coding the list of stable nuclides. We should be able to infer this from various data libraries, but the best solution may be to require/expect the specific activity to be generated in the ALARA run and use those results to filter the number density. (That is, if the user doesn't just look at the specific activity results, anyway.) I guess a question for @bohmt - the motivation is to remove the stable nuclides from overwhelming the result because they aren't important for other responses, but shouldn't users just look at those other responses? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #194.
I created a new issue within the FENDL3.x Validation Milestone for this PR that details the motivation for this new feature more specifically, but essentially, the purpose of the PR is to allow the user to ignore the stable isotopes of the irradiated target to see only new nuclides produced as a result of the reaction, whether stable or not.