feat: support js/ts config section in VS Code#2996
Merged
jasonlyu123 merged 1 commit intomasterfrom Mar 31, 2026
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #2970. This adds support for the new "js/ts" config section in VSCode by merging the modified "js/ts" value into the old format.
Important for non-VSCode users: This doesn't mean allowing the "js/ts" section in the language server. Currently, only "js/ts.hover.maximumLength" is read.
Implementation detail: I was originally going to copy the version for the TypeScript native preview extension. But the version they have now doesn't differentiate js and ts specific config like in the VSCode TypeScript extension.