[JavaJaxRS] enhance beanvalidation by adding @Valid

[nisargshah95]

Description

Using bean validation does not add @Valid annotation to codegen generated files. Similar ticket was filed for Java (#5498). The changes need to be ported to JavaJaxRS as well.

Swagger-codegen version

master (2.4.0)

Related issues/PRs

#5498 - [JAVA] enhance beanvalidation with adding @Valid

Suggest a fix/enhancement

Set of changes from PR #5517 can be applied

[deveshpujari]

Can someone fix this for JavaJaxRs in 2.4.0 ? Whole feature of bean validation in JavaJaxRS has become unusable because of this bug.
Thanks,

[HugoMario]

@deveshpujari, got it, let's fix this!

[nisargshah95]

This seems like a duplicate of #7651. @HugoMario you can close one of these at your will.

[deveshpujari]

@HugoMario
I looked at this little bit. Apart from the changes done in commit d08d55d it needs fix in api.mustache file also to add the {{>beanValidation}} . Also I am not sure if for nested objects @Valid is working or not.

[deveshpujari]

@HugoMario
Is there a way to add the message template in the swagger yaml file. Currently all annotations are generated like
@NotNull

but if i want with message.
@NotNull(message = "{contact.wrong.name}")

This way i can provide more specific message in the ValidationMessages.properties file.

[HugoMario]

i think we can use vendor extensions for that.

[HugoMario]

@deveshpujari ^^

[MariaPushkin]

I've fixed that by changing some mustache files, but my PR checks failed with exec-maven-plugin:1.2.1 on project PythonPetstoreClientTests. But I change nothing related to python. Maybe someone know what's wrong?

[deveshpujari]

@HugoMario
Is there any way we can add custom validation annotation in the yaml file. Like for for ipv4 format , i want to add my custom validators.

[deveshpujari]

i think we can use vendor extensions for that.

@HugoMario
Could you please provide an example on how to use the vendor extension ? Thanks.

[HugoMario]

hello @deveshpujari sorry for delay, here is a description about vendor extension https://github.com/swagger-api/swagger-codegen/wiki/Vendor-Extensions . let me know if you have any doubt or more question about it.

[miralexan]

@HugoMario @deveshpujari have either of you looked at @MariaPushkin's PR? I dont think it addresses the validator customization asks, but it looks like it fixes the base @Valid issue.