[JAX-RS] Show correct default value on CLI option description#3862
[JAX-RS] Show correct default value on CLI option description#3862wing328 merged 2 commits intoswagger-api:masterfrom
Conversation
|
After running ./bin/jaxrs-petstore-server.sh I've notices Is it OK for it to be CRLF? or should |
|
@y-higuchi I did a search for Can you tell me which line(s) you found |
|
(btw, I'm using latest master to check so please pull the latest master if you've not done so) |
|
I'm on fedb0cc so I think I'm on the latest master, but I am getting: Looking with Atom editor, it seems all lines in that file is CRLF |
|
OK. I'll take another look using another editor. Your change looks good. Thanks for the contribution :) |
|
I'm able to locate those ^M and will file a PR to clean those up this weekend. I'll also do a grep on all auto-generated code to ensure there's no ^M. Thanks for spotting the issue. |
|
@y-higuchi UPDATE: I've filed #3865 to fix the line breaks. |
* upstream/master: (79 commits) add undertow Add a new cli command to output version information (2nd attempt) swagger-api#3892 (swagger-api#3899) fix python flask controller without tag (default_controller) [aspnet5] Fix basePath application to operations (swagger-api#3911) Bugfix/issue 3723 (swagger-api#3726) Cgardens nested object regex (swagger-api#3879) [Cpprest] Fixing issue swagger-api#3773 (swagger-api#3876) escape callback parameter for java(okhttp) and python fix warning in html generator [PHP] fix PHPUnit invocation, add basic phpunit.xml.dist (swagger-api#3864) [Java] Remove duplicated model description in Spring, JAX-RS models (swagger-api#3887) [PHP] Better PSR2 compatibility (swagger-api#3863) Mention security script in pull request template [Swift] Use thread safe manager dictionary Replace ^M with new line (\r) in mustache template (swagger-api#3865) [swfit] fix url param with base name [JaxRS]Show correct default value on CLI option description (swagger-api#3862) add title, description to HTML output (swagger-api#3860) fix trailing comma in go api client fix typescript-fetch base path by removing ending slash ...
|
FYI. #4526 to detect the issue moving forward. |
wing328
changed the title
2 participants
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
Fixed jaxrs cli option handling to print correct default library template.
Fixes #3861