fix: keep quoted commas inside example slice and map values - #2183
Open
NoahStarkenburg wants to merge 1 commit into
Open
fix: keep quoted commas inside example slice and map values#2183NoahStarkenburg wants to merge 1 commit into
NoahStarkenburg wants to merge 1 commit into
Conversation
defineTypeOfExample split example values on every comma, so a quoted element like "a,b,c" was broken into separate items. Split on commas outside double quotes instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #899
A string slice example with quoted elements that contain commas was split on every comma, so
example:"\"a,b,c\",\"a,b,c\""produced["a", "b", "c", "a", "b", "c"]instead of["a,b,c", "a,b,c"].defineTypeOfExamplenow splits on commas that are outside double quotes, for both the array and object branches. Unquoted values behave exactly as before.Added tests covering quoted commas in array and object examples.