Skip to content

fix(cardStyl): Fix Card Height and adjust button position in card#1254

Open
EliasLeguizamon123 wants to merge 3 commits intoswapagarwal:masterfrom
EliasLeguizamon123:fix-cardsHeight
Open

fix(cardStyl): Fix Card Height and adjust button position in card#1254
EliasLeguizamon123 wants to merge 3 commits intoswapagarwal:masterfrom
EliasLeguizamon123:fix-cardsHeight

Conversation

@EliasLeguizamon123
Copy link
Copy Markdown

  • I've checked that this isn't a new swag opportunity proposal.
  • I've checked that this isn't a duplicate pull request.

Fix card component height, adding min height property

BEFORE:

devSwagBefore

AFTER:

devSwagAfter

MOBILE:

devSwagMobile

@EliasLeguizamon123 EliasLeguizamon123 changed the title Fix cards height fix(cardStyl): Fix Card Height and adjust button position in card Jan 20, 2024
@EliasLeguizamon123
Copy link
Copy Markdown
Author

hi @aslafy-z Could you take a quick look at my PR when you get a chance? I like to hear your thoughts on it, thanks.

@aslafy-z
Copy link
Copy Markdown
Collaborator

aslafy-z commented Oct 3, 2024

Hello @EliasLeguizamon123
Sorry for this late feedback.
Imo, the rule should not apply to mobile browsers. It makes cards too long for nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants