fix(typescript): Allow references to the global Symbol in computed property names under isolatedDeclarations#9869
Merged
kdy1 merged 4 commits intoswc-project:mainfrom Jan 23, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 1dddd25 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kdy1
previously approved these changes
Jan 13, 2025
Member
kdy1
left a comment
kdy1
left a comment
There was a problem hiding this comment.
I'll merge this when I'm going to create a breaking change of swc_core
Member
|
Can you rebase? |
CPunisher
force-pushed
the
fix/dts-symbol
branch
from
26c6534 to
6b65b50
Compare
kdy1
approved these changes
Jan 23, 2025
kdy1
changed the title
isolatedDeclarations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #9859
ref: microsoft/TypeScript#58771
Pass
unresolved_markto FastDts so it can check whether aSymbolident refs to global Symbol.