Add representations of GAL/BDS/GLO times and conversions between each#71
Merged
Conversation
b7f894c to
da46c22
Compare
da46c22 to
046bb3c
Compare
notoriaga
reviewed
Aug 16, 2021
notoriaga
approved these changes
Aug 16, 2021
silverjam
reviewed
Aug 16, 2021
Simplify tests. Fix typo in comments.
silverjam
approved these changes
Aug 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a couple of structs to represent Galileo, Beidou, and Glonass times. Galileo and Beidou are basically just constant offsets from GPS time.
libswiftnavdoesn't provide these representations natively, but it does provide the constant offsets so I've made it a bit easier to use with proper types and conversion functions. I also exposed a basic representation of the Glonass time struct, and the conversion to/from GPS time. To keep things simple I intentionally left out the functionality to add/remove time from GAL/BDS/GLO times.I also updated a couple of the existing documentation comments in the
time.rsfile.