Only crash in debug mode, if HTTPClient was not shutdown#478
Merged
fabianfett merged 1 commit intoswift-server:mainfrom Nov 17, 2021
Merged
Only crash in debug mode, if HTTPClient was not shutdown#478fabianfett merged 1 commit intoswift-server:mainfrom
fabianfett merged 1 commit intoswift-server:mainfrom
Conversation
fabianfett
force-pushed
the
ff-crash-debug-mode
branch
from
ca1853d to
b78674f
Compare
glbrntt
reviewed
Nov 17, 2021
| switch self.state { | ||
| case .shutDown: | ||
| break | ||
| case .shuttingDown, .upAndRunning: |
Collaborator
There was a problem hiding this comment.
Is it possible for .shuttingDown to ever be valid here? I.e. if using the async shutdown?
Member
Author
There was a problem hiding this comment.
You are right, when we are shuttingDown, the HTTPClient is in a retain cycle, that should prevent it from ever going out of memory. Do we want to call this out explicitly?
glbrntt
approved these changes
Nov 17, 2021
fabianfett
force-pushed
the
ff-crash-debug-mode
branch
from
b78674f to
4fedb63
Compare
dnadoba
approved these changes
Nov 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Generally we want to inform users that they need to shutdown their HTTPClient. Until
1.6.0we did this with an assert in HTTPClient's deinit. With1.6.0this behavior was raised to a precondition. This could lead to users to discover suddenly crashes in production, where they have seen none before.Changes
1.6.0Result