Pass request Task to FileDownloadDelegate reportHead and reportProgress closures#681
Merged
Lukasa merged 3 commits intoswift-server:mainfrom Apr 13, 2023
Merged
Conversation
…tProgress` closures ### Motivation If the HTTP response status is not 2xx or the file being downloaded becomes too big, it is desirable to cancel the file download eagerly. This is currently quite hard because the `reportHead` and `reportProgress` closures do not have direct access to the `HTTPClient.Task`. ### Modifications - Pass `HTTPClient.Task` additionally to `reportHead` and `reportProgress` closures ### Result A file download can now easily be cancelled at any time.
MaxDesiatov
approved these changes
Apr 12, 2023
Member
MaxDesiatov
left a comment
MaxDesiatov
left a comment
There was a problem hiding this comment.
This looks like a quite more elegant solution. Much appreciated!
Lukasa
approved these changes
Apr 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
If the HTTP response status is not 2xx or the file being downloaded becomes too big, it is desirable to cancel the file download eagerly. This is currently quite hard because the
reportHeadandreportProgressclosures do not have direct access to theHTTPClient.Task.Modifications
HTTPClient.Taskadditionally toreportHeadandreportProgressclosuresResult
A file download can now easily be cancelled at any time.