Skip to content

Typos: test/IRGen#75030

Merged
AnthonyLatsis merged 1 commit intoswiftlang:mainfrom
Sajjon:cyon_typo_batch__test__IRGen
Aug 9, 2024
Merged

Typos: test/IRGen#75030
AnthonyLatsis merged 1 commit intoswiftlang:mainfrom
Sajjon:cyon_typo_batch__test__IRGen

Conversation

@Sajjon
Copy link
Copy Markdown
Contributor

@Sajjon Sajjon commented Jul 7, 2024

Fix typos in test/IRGen

This is one batch of many PRs fixing typos, see the tracking issue.

@Sajjon Sajjon requested a review from rjmccall as a code owner July 7, 2024 13:21
@Sajjon Sajjon mentioned this pull request Jul 7, 2024
Comment thread test/IRGen/weak_import_availability.swift Outdated
Comment thread test/IRGen/ptrauth-dynamic_replaceable.sil Outdated
Comment thread test/IRGen/weak_import_availability.swift Outdated
@Sajjon
Copy link
Copy Markdown
Contributor Author

Sajjon commented Jul 12, 2024

@AnthonyLatsis all suggestions applied :)

Comment thread test/IRGen/dynamic_replaceable.sil Outdated
@Sajjon
Copy link
Copy Markdown
Contributor Author

Sajjon commented Aug 8, 2024

@AnthonyLatsis I've squashed and rebased on main, and I think applied suggested changes?

Anything more I need to do to get this merge ready?

@AnthonyLatsis AnthonyLatsis self-assigned this Aug 8, 2024
@AnthonyLatsis
Copy link
Copy Markdown
Collaborator

@swift-ci please smoke test

Copy link
Copy Markdown
Collaborator

@AnthonyLatsis AnthonyLatsis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Not a code owner of this area, but I am going to assume I have their trust in my judgement in this sort of case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants