Enable setting export image sizes #340
Merged
jacalata merged 7 commits intodevelopmentfrom Jan 10, 2025
Merged
Conversation
This will verify that the command can run, but to confirm the filtering would need a visual check
This now supports the get command with url params ?:size=x,y and the export command with options --height, --weight
| if args.height: | ||
| request_options.viz_height = int(args.height) | ||
| if args.width: | ||
| request_options.viz_width = args.width |
Contributor
There was a problem hiding this comment.
I think you meant to do int(args.width)
stephendeoca
approved these changes
Jan 10, 2025
e359480 to
075f872
Compare
075f872 to
400fa4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This PR is built on top of the open workbook filtering PR)
This now supports the get command with url params ?:size=x,y
and the export command with options --height, --weight
closes #94