Open
Conversation
When the VPN is disconnected, stopSelf() triggers onDestroy(), which calls close(). onRevoke() also calls close(). Both these calls do serviceDisconnect on the service, sending the service to the onDisconnect channel twice. This fix: -only calls CloseTuns for the current VPN service (unconditional call was killing the newly established VPN) -calls setWantRunning(false) when a VPN revokes Tailscale to -check permissions and prepare VPN service before starting the VPN, since VPN permission is revoked in onRevoke Fixes tailscale/tailscale#17190 Signed-off-by: kari-ts <kari@tailscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the VPN is disconnected, stopSelf() triggers onDestroy(), which calls close(). onRevoke() also calls close(). Both these calls do serviceDisconnect on the service, sending the service to the onDisconnect channel twice. This fix:
-only calls CloseTuns for the current VPN service (unconditional call was killing the newly established VPN) -calls setWantRunning(false) when a VPN revokes Tailscale to -check permissions and prepare VPN service before starting the VPN, since VPN permission is revoked in onRevoke
Fixes tailscale/tailscale#17190