Setup OIDC publishing#19943
Conversation
WalkthroughThe pull request consolidates GitHub Actions release workflows by removing the dedicated insiders release workflow and integrating its functionality into the main release workflow. The release workflow now accepts a required 🚥 Pre-merge checks | ✅ 1 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/release.yml (1)
350-360: Consider if Play updates should trigger for insiders releases.This step now runs unconditionally for both
insidersandreleasechannels. If frequent Play updates from insiders releases are undesirable, consider adding a condition:if: env.RELEASE_KIND == 'release'🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/release.yml around lines 350 - 360, The "Trigger Tailwind Play update" workflow step currently runs for all release kinds; restrict it to only run for production releases by adding a conditional that checks the RELEASE_KIND environment variable (e.g., ensure the step with name "Trigger Tailwind Play update" or the job invoking actions/github-script@v8 is guarded with if: env.RELEASE_KIND == 'release') so insiders releases won't trigger the Play update.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/release.yml:
- Around line 350-360: The "Trigger Tailwind Play update" workflow step
currently runs for all release kinds; restrict it to only run for production
releases by adding a conditional that checks the RELEASE_KIND environment
variable (e.g., ensure the step with name "Trigger Tailwind Play update" or the
job invoking actions/github-script@v8 is guarded with if: env.RELEASE_KIND ==
'release') so insiders releases won't trigger the Play update.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: a83fbf7e-4c15-4a5f-954a-40c9d8358e83
📒 Files selected for processing (3)
.github/workflows/prepare-release.yml.github/workflows/release-insiders.yml.github/workflows/release.yml
💤 Files with no reviewable changes (1)
- .github/workflows/release-insiders.yml
This PR merges the
release-insiders.ymlandrelease.ymlsuch that we can setup OIDC publishing to npmjs.com.