Skip to content

Notebooks 3/4: run cells from the side-pane notebook viewer #212

Closed

Description

@tannerpolley

Part of #208, after 2/4. Design doc: ~/.local/share/t3-fork-notes/notebook-execution-design.md, sections 3 and 7 (PR 3).

A small hook in upstream's NotebookPreview.tsx adds Run, Run all, Interrupt and Restart, live outputs, dirty/save/conflict/reconnect states, and a static fallback when no Jupyter server is available. Sanitize outputs. Use components/ui primitives without restyling them. Focused browser tests; the visual proof is a capture.

Activity

  1. tannerpolley commented on Oct 28, 2026

    @tannerpolley
    OwnerAuthor

    T3 Code status: Unavailable

    Issue: #212 Notebooks 3/4: run cells from the side-pane notebook viewer

    Thread: thread:delegated-task:command%3Amcp%3Aa8ce7407-d2f3-4841-a9d3-0d27e822c8de%3Adelegate-task%3Anotebooks-208-212-implement-20261028

    Model: gpt-6.1-sol

    Branch: issue-212-notebooks-3-4-run-cells-from-the-side

    Updated: 2026-11-13T05:08:10.512Z

  2. tannerpolley commented on Oct 28, 2026

    @tannerpolley
    OwnerAuthor

    T3 Code closeout: done

    Issue: #212 Notebooks 3/4: run cells from the side-pane notebook viewer
    Thread: thread:delegated-task:command%3Amcp%3Aa8ce7407-d2f3-4841-a9d3-0d27e822c8de%3Adelegate-task%3Anotebooks-208-212-implement-20261028
    Model: gpt-6.1-sol
    Branch: issue-212-notebooks-3-4-run-cells-from-the-side
    Completed: 2026-10-28T23:42:43.617Z

    Implemented #212 and committed locally. Working tree is clean.

    • Commit: 24f77861e84f08a7927d87cf9879e1fcd56b40a9
    • Branch: issue-212-notebooks-3-4-run-cells-from-the-side
    • Worktree: /home/tnnrpolley21/Workspaces/Applications/t3code/.worktrees/issue-212-notebooks-3-4-run-cells-from-the-side

    The workspace notebook hook now provides Run cell, Run all, Interrupt, Restart, and Save through destination-environment T3 RPC. It includes cell-local live outputs, execution counts and provenance, unknown/reconnect states, permission-controlled actions, and static fallback. Rendering reuses the existing output decoder, sanitizer, isolated HTML frames, and incremental cell reveal.

    Dirty closing offers Save, retain draft, or discard, including for inactive tabs and disconnected viewers. Discard uses a new protected, revision-checked server reload method under the existing notebook lock; it does not write the disk file.

    Entry points covered: workspace file side pane and artifact workspace opens through the same dispatch hook. Desktop inherits web behavior. Attachments remain static; mobile and MCP are outside this change.

    Validation:

    • Focused web run: 37 tests passed, including 3 browser cases.
    • Final affected gate: 160 tests passed across 9 files; format, lint, and GraphQL checks passed.
    • Server, web, contracts, and client-runtime typechecks passed.
    • check:changed remains blocked only by the established baseline: 3 mobile type errors, 3 Knip files, and 74 Knip exports.

    Evidence: live viewer capture, static sanitized-output capture, final gate log.

    No push, PR, merge, dev server, interactive browser session, install/restart, or release was performed. Independent checker review and the primary orchestrator’s separately authorized integrated preview remain open.

  3. tannerpolley commented on Oct 29, 2026

    @tannerpolley
    OwnerAuthor

    T3 Code closeout: done

    Issue: #212 Notebooks 3/4: run cells from the side-pane notebook viewer
    Thread: thread:delegated-task:command%3Amcp%3Aa8ce7407-d2f3-4841-a9d3-0d27e822c8de%3Adelegate-task%3Anotebooks-208-212-implement-20261028
    Model: gpt-6.1-sol
    Branch: issue-212-notebooks-3-4-run-cells-from-the-side
    Completed: 2026-10-29T03:22:24.667Z

    Correction round 1 is complete at 778389588ef60a75ba9ff5833538488e7a1e6685, with a clean working tree. Independent checker re-review and the orchestrator’s integrated preview remain the open gates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions