Repository navigation
chore: clear the 81 unused exports so the commit hook passes - #392
Merged
tannerpolley merged 2 commits intoNov 13, 2026
Merged
Conversation
Drops `export` from helpers only their own file uses, and deletes code nothing uses (dead test-harness helpers and web logic helpers). No behavior change. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…sed export (#256) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
tannerpolley
marked this pull request as ready for review
November 13, 2026 20:26
tannerpolley
deleted the
issue-256-commit-hook-fails-on-every-typescript
branch
November 13, 2026 20:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #256.
vp run knip:checkreported 81 unused exports onmain, so every TypeScript commit failed the pre-commit hook. This clears all 81 with no behavior change.exportwhere only the file itself uses the name (server scanners and workers, web logic modules,tokenizeShell,inlineShellContext, and similar).ContextWindowMeter.logic,Sidebar.logic,UsageLimits) plussubagentResultOwed, with the imports and constants they left behind.delegatedTaskModesfromOrchestratorMcpService.ts(evals import it directly) andformatDurationfromsession-logic.ts.shellCommand.tsand removed an unused lint directive ininlineShell.ts, because the hook lints staged files.Ignored (upstream-owned; upstream leaves it unused):
WorktreesDirectoryRowinapps/web/src/components/settings/StorageSettings.tsx, via a knipignoreIssuesentry. That file stays identical tomain/upstream so upstream edits to it don't conflict. No other ignore entries were needed.Checks:
vp run check:changedpasses format, lint, both knip passes, graphql, 28 test files (749 tests) and React Compiler. Typecheck passes everywhere exceptapps/mobile, which has 3 errors in files this PR does not touch (ComposerCommandPopover.tsx,projectIcon.ts,asset-url-state.ts). The commit hook passed without--no-verify.🤖 Generated with Claude Code