fix: [TD-37190] Disable ignore_nodata_trigger when window type is not interval/sliding or period.#32405
Merged
guanshengliang merged 1 commit intomainfrom Aug 6, 2025
Merged
Conversation
Simon9997
requested review from
dapan1121,
guanshengliang and
hzcheng
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a validation issue in stream creation by disabling the ignore_nodata_trigger option when the window type is not interval, sliding, or period. The change adds a validation check to prevent an unsupported configuration combination.
Key Changes
- Added validation logic to check window type before allowing
ignore_nodata_triggeroption - Returns appropriate error message when unsupported combination is detected
… interval/sliding or period.
Simon9997
force-pushed
the
fix/main/TD-37190
branch
from
2e027a5 to
ca0f197
Compare
hjxilinx
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Disable ignore_nodata_trigger when window type is not interval/sliding or period.
Checklist
Please check the items in the checklist if applicable.