tidy up CI case for link function#33253
Conversation
…gine into case/TD-38265-MAIN
Summary of ChangesHello @DuanKuanJun, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a comprehensive cleanup and reorganization of CI test cases, particularly those related to functions. It introduces a new mechanism for parsing docstring labels to control test execution, standardizes docstring formats across a wide range of function tests, and restructures test file paths for better organization. Additionally, new dedicated test cases have been added for several scalar functions, enhancing test coverage and clarity. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request tidies up test cases, primarily for CI and documentation generation. It introduces a script to handle special 'ignore' labels in docstrings, reorganizes many test files, and refactors a large test function into smaller methods. My review focuses on a bug in the markdown generation script, an incomplete refactoring, an empty placeholder test, and several areas for improvement in a new test file, including a bug in test assertions and some style issues. While the reorganization is a positive step, some parts require further attention to ensure correctness and maintainability.
test/cases/22-Functions/04-Timeseries/test_fun_ts_derivative.py
Outdated
Show resolved
Hide resolved
test/cases/22-Functions/04-Timeseries/test_fun_ts_derivative.py
Outdated
Show resolved
Hide resolved
test/cases/22-Functions/04-Timeseries/test_fun_ts_derivative.py
Outdated
Show resolved
Hide resolved
…o case/TD-38265-MAIN
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #33253 +/- ##
==========================================
- Coverage 54.05% 50.22% -3.84%
==========================================
Files 472 437 -35
Lines 294900 268959 -25941
Branches 99139 94802 -4337
==========================================
- Hits 159397 135073 -24324
- Misses 83784 84764 +980
+ Partials 51719 49122 -2597
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
Description
Please briefly describe the code changes in this pull request.
Checklist
Please check the items in the checklist if applicable.