fix/TD-38490-reset-heartbeat-after-mnode-leader-restart

[cadem]

Description

Please briefly describe the code changes in this pull request.

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @cadem, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue related to the arbitration group's heartbeat mechanism, particularly in scenarios involving mnode leader restarts. The primary change involves ensuring that heartbeat timestamps are correctly initialized when an arbitration group's state is decoded, preventing potential timeout issues. Additionally, several fields within the SArbAssignedLeader structure have been renamed for better readability and consistency, and logging has been enhanced to provide more detailed insights into heartbeat processing.

Highlights

• Refactored Arbitration Leader Fields: Renamed dnodeId to assignedDnodeId and acked to assignAcked within the SArbAssignedLeader structure for improved clarity and semantic accuracy across the codebase.
• Heartbeat Timestamp Initialization: Modified the mndArbGroupActionDecode function to initialize pMember->state.lastHbMs with the current timestamp (nowMs) instead of 0. This ensures proper heartbeat tracking, especially after a leader restart or state reconstruction, preventing potential timeout issues.
• Logging Enhancements: Improved logging in mndArbIsNeedUpdateTokenByHeartBeat by including the vgId in an error message and added conditional mInfo/mTrace logging for heartbeat responses in mndProcessArbHbRsp for better debugging and visibility into heartbeat processing.
• Test Case Updates: Updated existing test cases in arbgroup.cpp to align with the renamed fields (assignedDnodeId and assignAcked), ensuring continued correctness of the arbitration group logic.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request primarily addresses an issue with heartbeat reset after an mnode leader restart by correctly initializing the last heartbeat timestamp. It also includes a valuable refactoring that renames fields in the SArbAssignedLeader struct for better clarity, with these changes propagated throughout the codebase. While the main fix and refactoring are well-implemented, I've identified a pre-existing critical use-after-free bug in a function that was modified. This bug could lead to system instability and should be addressed.