[6755488313]: add-check-key

[cadem]

Description

Issue(s)

• Close/close/Fix/fix/Resolve/resolve: Issue Link

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @cadem, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a critical validation step during the database creation process. It prevents the system from creating a new database if the provided encryption key (tsDataKey) is empty. This enhancement improves the robustness and security of the database system by enforcing proper encryption key management from the outset, thereby mitigating potential vulnerabilities associated with misconfigured or absent encryption keys.

Highlights

• Encryption Key Validation: A new validation check has been added to the mndProcessCreateDbReq function. This check ensures that the tsDataKey (encryption key) is not an empty string when a new database is being created. If an empty key is detected, the function now returns TSDB_CODE_DNODE_INVALID_ENCRYPTKEY and logs an appropriate error message.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds a necessary validation check in the database creation process. When a database is requested with encryption, it now verifies that an encryption key (tsDataKey) is configured. If the key is missing, the creation fails with an appropriate error. This is a good improvement for robustness. I have one minor suggestion to optimize the key check for better performance.

[Copilot]

Pull request overview

Adds an additional validation during database creation to ensure an encryption key is present when creating an audit database.

Changes:

• Add a check that rejects audit DB creation if tsDataKey is empty.
• Return TSDB_CODE_DNODE_INVALID_ENCRYPTKEY when the encryption key is missing.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.