Skip to content

fix: execute taos shell timeout 10->120s#34466

Merged
guanshengliang merged 2 commits intomainfrom
fix/TD-6765019970-MAIN
Feb 3, 2026
Merged

fix: execute taos shell timeout 10->120s#34466
guanshengliang merged 2 commits intomainfrom
fix/TD-6765019970-MAIN

Conversation

@DuanKuanJun
Copy link
Copy Markdown
Contributor

Description

Issue(s)

  • Close/close/Fix/fix/Resolve/resolve: Issue Link

Checklist

Please check the items in the checklist if applicable.

  • Is the user manual updated?
  • Are the test cases passed and automated?
  • Is there no significant decrease in test coverage?

Copilot AI review requested due to automatic review settings February 2, 2026 04:31
@DuanKuanJun DuanKuanJun requested a review from a team as a code owner February 2, 2026 04:31
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @DuanKuanJun, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses potential test flakiness and failures in the taos shell test suite by extending command execution and expectation timeouts. It also significantly improves the diagnostic capabilities of these tests through the introduction of detailed, timestamped logging for process interactions and SQL command outcomes, making it easier to debug and understand test behavior.

Highlights

  • Increased Timeouts: The timeouts for spawning the taos shell process and expecting output have been significantly increased from 10-20 seconds to 120 seconds to prevent premature test failures on slow systems or during long-running operations.
  • Enhanced Logging: A new logPrint utility function has been introduced to provide timestamped output, and extensive debug logging has been added throughout the taos_command execution flow, including detailed information about SQL commands sent and their results.
  • Improved SQL Execution Handling: The logic for handling SQL command execution results has been refined to include 'Drop OK' as a success condition and to provide more specific error messages for timeouts or unexpected process termination.
  • Platform-Specific Output Decoding: Added platform-specific handling for decoding pexpect output (child.before and child.after) to ensure compatibility across different operating systems, particularly Windows.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a timeout issue in the taos_shell test by increasing the timeout from 10s/20s to 120s. It also introduces a logPrint function and adds extensive debug logging to help diagnose issues. The changes are functional, but I have a few suggestions to improve maintainability and code quality. My feedback includes recommendations for consistent logging, using specific exception handling, avoiding hardcoded values, and improving code style for better readability.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the taos shell system test to use a longer timeout and adds more detailed timestamped debugging output to help diagnose slow/blocked CLI interactions.

Changes:

  • Increased taosExpect.spawn() / expect() timeouts up to 120 seconds for taos shell login and SQL execution.
  • Added a timestamped logPrint() helper and additional debug logs around process spawn, login expect, and SQL expect output.
  • Added a final tdLog.success(...) message when the test completes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@guanshengliang guanshengliang merged commit b1cdfa6 into main Feb 3, 2026
7 of 8 checks passed
@guanshengliang guanshengliang deleted the fix/TD-6765019970-MAIN branch February 3, 2026 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants