Skip to content

Fixed issues with no total number #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Quorafind merged 1 commit into from
Jun 23, 2022
Merged

Fixed issues with no total number #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"id": "obsidian-task-progress-bar",
"name": "Task Progress Bar",
"version": "1.3.0",
"version": "1.3.1",
"minAppVersion": "0.15.2",
"description": "A task progress bar plugin for tasks in Obsidian.",
"author": "Boninall",
"authorUrl": "https://github.com/Quorafind",
"isDesktopOnly": false
}
}
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "obsidian-task-progress-bar",
"version": "1.1.0",
"version": "1.3.1",
"description": "A task progress bar plugin for tasks in Obsidian.",
"main": "main.js",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion src/taskProgressBarWidget.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ class TaskProgressBarWidget extends WidgetType {
progressBackGroundEl.setAttribute('class', 'progress-bar-inline-background');
progressEl.setAttribute('class', 'progress-bar-inline');

if (this.plugin?.settings.addNumberToProgressBar) {
if (this.plugin?.settings.addNumberToProgressBar && this.total && this.completed) {
const numberEl = document.createElement('div');
numberEl.setAttribute('class', 'progress-status');
numberEl.appendChild(document.createTextNode('[' + this.completed + '/' + this.total + ']'));
Expand Down
4 changes: 3 additions & 1 deletion versions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
"1.0.1": "0.12.0",
"1.0.2": "0.12.0",
"1.1.0": "0.12.0",
"1.1.1": "0.12.0",
"1.2.0": "0.15.2",
"1.3.0": "0.15.2"
"1.3.0": "0.15.2",
"1.3.1": "0.15.2"
}