Improve validation errors and log test duration#996
Open
MaximIgitov wants to merge 1 commit intotaverntesting:masterfrom
Open
Improve validation errors and log test duration#996MaximIgitov wants to merge 1 commit intotaverntesting:masterfrom
MaximIgitov wants to merge 1 commit intotaverntesting:masterfrom
Conversation
Comment on lines
+301
to
+306
| duration = time.perf_counter() - start_time | ||
| logger.info( | ||
| "tavern.test_duration_seconds=%0.3f test=%s", | ||
| duration, | ||
| self.name, | ||
| ) |
Member
There was a problem hiding this comment.
Can you remove this timing? This can already be done with a fixture like in the docs: https://tavern.readthedocs.io/en/latest/basics.html#usefixtures
| real_context.append( | ||
| f""" | ||
| {c.message} | ||
| {_format_validation_message(c)} |
Member
There was a problem hiding this comment.
This definitely is something that is currently a bit messy and could be improved, could you add a docstring to the above functions or just an example of before/after to compare what's changed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan