Normative: add Iterator Helpers by michaelficarra · Pull Request #3395 · tc39/ecma262

michaelficarra · 2024-08-16T02:07:51Z

https://github.com/tc39/proposal-iterator-helpers

michaelficarra · 2024-08-16T22:17:11Z

spec.html


+    <emu-clause id="sec-getiteratorflattenable" type="abstract operation">
+      <h1>
+        GetIteratorFlattenable (


I would love to come up with a better name for this AO.

This comment was about GetIteratorFlattenable (it's no longer displaying under the appropriate line in the diff view).

looks right on the conversation view, at least

spec.html

michaelficarra · 2024-09-06T14:42:42Z

FYI we're having a relevant editorial discussion here: tc39/proposal-joint-iteration#30

spec.html

ljharb

This PR seems to be missing changes to CreateIteratorFromClosure to add a 4th argument? (present in the proposal spec)

spec.html

michaelficarra · 2024-10-10T07:12:58Z

@tc39/ecma262-editors Do we want to make the [[UnderlyingIterator]] internal slot plural (as is required by upcoming proposal joint iteration) as part of this PR, or should we do it in 2 phases?

bakkot

LGTM. I no longer think we should rename [[UnderlyingIterators]] now, since it would also involve changing its handling; we can do that in the followup.

jmdyck · 2024-10-20T14:27:47Z

spec.html

+            1. If _O_.[[GeneratorState]] is ~suspended-start~, then
+              1. Set _O_.[[GeneratorState]] to ~completed~.
+              1. NOTE: Once a generator enters the completed state it never leaves it and its associated execution context is never resumed. Any execution state associated with _O_ can be discarded at this point.
+              1. Perform ? IteratorClose(_O_.[[UnderlyingIterator]], ReturnCompletion(*undefined*)).


It seems like this Return Completion could be returned by IteratorClose, and thus by this algorithm, and thus by the [[Call]] for this built-in. But the invariants for essential internal methods don't allow [[Call]] to return a Return Completion.

Co-authored-by: Michael Ficarra <m.ficarra@f5.com> Co-authored-by: Michael Dyck <jmdyck@ibiblio.org>

changes addressed

Follows tc39/ecma262#3395.

Co-authored-by: Michael Ficarra <m.ficarra@f5.com> Co-authored-by: Michael Dyck <jmdyck@ibiblio.org>

ljharb · 2025-02-12T19:59:47Z

spec.html

            </tr>
            <tr>
              <td>
-                %IteratorPrototype%


i missed this removal; the intention was to keep pre-existing intrinsics in this table. i'll make a PR to re-add %IteratorPrototype% in the future.

michaelficarra mentioned this pull request Aug 16, 2024

stage 4 tracking tc39/proposal-iterator-helpers#284

Closed

14 tasks

michaelficarra force-pushed the iterator-helpers-integration branch from 7879f32 to 0bf3656 Compare August 16, 2024 15:24

michaelficarra commented Aug 16, 2024

View reviewed changes

michaelficarra force-pushed the iterator-helpers-integration branch from 2db9b31 to 78c9237 Compare August 16, 2024 23:14

This comment was marked as resolved.

Sign in to view

michaelficarra force-pushed the iterator-helpers-integration branch from b7e5f5f to 189e3d6 Compare August 19, 2024 17:27

jmdyck previously requested changes Aug 20, 2024

View reviewed changes

michaelficarra force-pushed the iterator-helpers-integration branch 2 times, most recently from 2255ce1 to 0cb2376 Compare September 5, 2024 00:03

michaelficarra force-pushed the iterator-helpers-integration branch 2 times, most recently from 322876c to 380047c Compare September 23, 2024 21:10

ljharb reviewed Sep 26, 2024

View reviewed changes

spec.html Show resolved Hide resolved

ljharb reviewed Sep 26, 2024

View reviewed changes

syg approved these changes Sep 26, 2024

View reviewed changes

spec.html Outdated Show resolved Hide resolved

spec.html Outdated Show resolved Hide resolved

michaelficarra mentioned this pull request Sep 27, 2024

Fix IteratorStep usage in Iterator.prototype.drop tc39/proposal-iterator-helpers#300

Closed

michaelficarra added has stage 4 This PR represents a proposal that has achieved stage 4, and is ready to merge. and removed pending stage 4 This proposal has not yet achieved stage 4, but may otherwise be ready to merge. labels Oct 8, 2024

michaelficarra requested a review from bakkot October 8, 2024 04:25

fisker mentioned this pull request Oct 9, 2024

Iterator should in ES* files sindresorhus/globals#266

Closed

michaelficarra added the editor call to be discussed in the next editor call label Oct 10, 2024

azu mentioned this pull request Oct 10, 2024

ES2025: Iterator Helpers js-primer/js-primer#1601

Closed

bakkot approved these changes Oct 17, 2024

View reviewed changes

michaelficarra added ready to merge Editors believe this PR needs no further reviews, and is ready to land. and removed editor call to be discussed in the next editor call labels Oct 17, 2024

jmdyck reviewed Oct 20, 2024

View reviewed changes

Normative: add Iterator Helpers (#3395)

961f269

Co-authored-by: Michael Ficarra <m.ficarra@f5.com> Co-authored-by: Michael Dyck <jmdyck@ibiblio.org>

ljharb force-pushed the iterator-helpers-integration branch from 60fcae2 to 961f269 Compare October 20, 2024 21:29

ljharb merged commit 961f269 into main Oct 20, 2024

ljharb deleted the iterator-helpers-integration branch October 20, 2024 21:45

michaelficarra added the editor call to be discussed in the next editor call label Oct 21, 2024

linusg mentioned this pull request Oct 21, 2024

Uppercase "Iterator" falsely autolinks to constructor #3455

Closed

bakkot mentioned this pull request Oct 21, 2024

Editorial: fix IteratorClose call in %IteratorHelperPrototype%.return #3457

Merged

bakkot removed the editor call to be discussed in the next editor call label Oct 23, 2024

domenic added a commit to whatwg/webidl that referenced this pull request Oct 28, 2024

Fix Iterator prototype reference

a9d3bf6

Follows tc39/ecma262#3395.

domenic mentioned this pull request Oct 28, 2024

Fix Iterator prototype reference whatwg/webidl#1446

Merged

domenic added a commit to whatwg/webidl that referenced this pull request Oct 29, 2024

Fix Iterator prototype reference

33c2eec

Follows tc39/ecma262#3395.

chances mentioned this pull request Nov 8, 2024

Type Declarations for Iterator.from denoland/deno#26783

Closed

kimjg1119 pushed a commit to kimjg1119/ecma262 that referenced this pull request Nov 20, 2024

Normative: add Iterator Helpers (tc39#3395)

15ef62f

Co-authored-by: Michael Ficarra <m.ficarra@f5.com> Co-authored-by: Michael Dyck <jmdyck@ibiblio.org>

ptomato mentioned this pull request Feb 12, 2025

Some improvements to well-known intrinsic objects harness file tc39/test262#4392

Merged

ljharb reviewed Feb 12, 2025

View reviewed changes

stonechoe added a commit to es-meta/esmeta that referenced this pull request Jun 9, 2025

fix: Reflect recent changes in tc39/ecma262#3395

c78eaf8

stonechoe added a commit to es-meta/esmeta that referenced this pull request Jun 26, 2025

fix: Reflect recent changes in tc39/ecma262#3395

ca0ae77

stonechoe mentioned this pull request Jun 27, 2025

Update to ES2025 es-meta/esmeta#286

Merged

stonechoe added a commit to es-meta/esmeta that referenced this pull request Jun 27, 2025

fix: Reflect recent changes in tc39/ecma262#3395

ed5fa2a

avivkeller mentioned this pull request Aug 28, 2025

[Node.js v22 Only] New Helpers webpack/hackathon#22

Open

Conversation

michaelficarra commented Aug 16, 2024

Uh oh!

michaelficarra Aug 16, 2024

Choose a reason for hiding this comment

Uh oh!

michaelficarra Sep 18, 2024

Choose a reason for hiding this comment

Uh oh!

ljharb Sep 23, 2024

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

michaelficarra commented Sep 6, 2024

Uh oh!

Uh oh!

ljharb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

michaelficarra commented Oct 10, 2024

Uh oh!

bakkot left a comment

Choose a reason for hiding this comment

Uh oh!

jmdyck Oct 20, 2024

Choose a reason for hiding this comment

Uh oh!

ljharb Feb 12, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants