Repository navigation
Editorial: Don't mention writability in the Global Environment Record GetBindingValue description - #4042
Open
bakkot wants to merge 1 commit into
Open
Editorial: Don't mention writability in the Global Environment Record GetBindingValue description#4042bakkot wants to merge 1 commit into
bakkot wants to merge 1 commit into
Conversation
nicolo-ribaudo
approved these changes
Oct 29, 2026
linusg
approved these changes
Oct 29, 2026
linusg
left a comment
linusg
left a comment
Member
There was a problem hiding this comment.
I find the "normally already exists" wording a little odd, but that's a separate cleanup.
|
The rendered spec preview for this PR is available as a single page at https://tc39.es/ecma262/pr/4042 and as multiple pages at https://tc39.es/ecma262/pr/4042/multipage . |
bakkot
changed the title
gibson042
changed the title
gibson042
approved these changes
Oct 30, 2026
gibson042
added
the
ready to merge
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetBindingValue does not care about writability (as you can confirm by reading the algorithm and seeing that it will bottom out in GetBindingValue for Object environment records). Presumably this was copied from the SetMutableBinding section above it when this section was introduced in ES2015.
Cherry-pick of the commit from #4012 by @JinDX.