yield an undersized window when windows cannot yield at least 1 full one#15
Closed
michaelficarra wants to merge 3 commits into
Closed
yield an undersized window when windows cannot yield at least 1 full one#15michaelficarra wants to merge 3 commits into
michaelficarra wants to merge 3 commits into
Conversation
bakkot
reviewed
May 13, 2025
bakkot
reviewed
May 13, 2025
Co-authored-by: Kevin Gibbons <bakkot@gmail.com>
Co-authored-by: Kevin Gibbons <bakkot@gmail.com>
bakkot
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one of four possible behaviours.
.next(): throw on.next()whenwindowscannot yield at least 1 full window #14undefined: pad an undersized first window with undefined #16Closes #13.