generated from tc39/template-for-proposals
-
Notifications
You must be signed in to change notification settings - Fork 0
Add draft spec text for TypedArray.concat #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+3,031
−49
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7672833
Add draft spec text for TypedArray.concat
jasnell 8988a70
Address ToIndex review comment
jasnell e9f6264
Add editorial note about the high-level description
jasnell 45716ea
Address multiple discussion points
jasnell 7908692
More clarifications/fixups
jasnell 712e630
cleaups + add SharedArrayBuffer.concat
jasnell 39c7d61
Document the test cases
jasnell b439771
Add polyfil
jasnell 6de6b31
remove the polyfill
jasnell cabaae2
Fixups to conform to editorial guidelines
jasnell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementations are always free to implement using any strategy which behaves as-if it was using the algorithm in the spec text. I strongly expect they'll implement this using exactly the same logic they use for
TA.prototype.set.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do an editorial clean up on this in a follow up pass