Fix(bds): 아바타 컴포넌트 기본 프로필 컬러 변경#483
Merged
Merged
Conversation
jeonghoon11
requested review from
1jiwoo27,
gwagjiug,
hansoojeongsj,
jogpfls and
minjeoong
and removed request for
a team
Contributor
|
✅ Storybook이 배포되었습니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
해당 PR에 대한 작업 내용을 요약하여 작성해주세요.
📚 Tasks
1차 스프린트때 아바타 컴포넌트의 기본 이미지가 변경됐어요.
이전 마이 페이지의 이미지 없을 때의 Avatar 컴포넌트는
profile_none, 커뮤니티 페이지의 Avatar 컴포넌트는profile_fill이 적용됐지만이번 스프린트때 모든 기본 Avatar 컴포넌트의 색이 grayScale로 변경되어 수정했습니다.
따라서
profile_none과profile_fill은 제거하고proflieIcon만 렌더링하도록 수정했습니다.추가로 커뮤니티 대댓글 컴포넌트에서 대댓글 아이콘의 사이즈 때문에 글이 옆으로 밀려있는걸 발견했어요.
width와height가 잘못 지정되어 있는걸 발견했고 수정했어요.스토리북도 이전에 너무 지저분해 보여서 깔끔하게 보이도록 수정했습니다!
📸 Screenshot
[AS-IS]
[TO-BE]