Add namespace level pruner config controller#14
Add namespace level pruner config controller#14anithapriyanatarajan merged 1 commit intotektoncd:mainfrom
Conversation
|
@infernus01 Thankyou for the PR. Please consider including a watcher in the namespace controller for namespace deletion. Whenever a namespace is deleted, update the configstore to remove the config values specific to the namespace. |
f7f795f to
e44c4b9
Compare
e44c4b9 to
c054a9d
Compare
config/200-clusterrole.yaml
Outdated
| verbs: | ||
| - update | ||
|
|
||
| # Read permissions for ConfigMaps across all namespaces (for namespace-level pruner config) |
There was a problem hiding this comment.
To make sure the role provides least required access please consider including the resourceName for get and watch atleast.
# List permission - required for informer setup (cannot use resourceNames)
- apiGroups:
- ""
resources:
- configmaps
verbs:
- list
# Get/Watch permission - restricted to specific ConfigMap name
- apiGroups:
- ""
resources:
- configmaps
resourceNames:
- tekton-pruner-namespace-spec
verbs:
- get
- watch
anithapriyanatarajan
left a comment
There was a problem hiding this comment.
Please update the cluster role
Signed-off-by: Shubham Bhardwaj <shubbhar@redhat.com>
c054a9d to
08562d8
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anithapriyanatarajan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes