Do not set OTel span error status for benign exceptions#530
Merged
cretz merged 1 commit intotemporalio:mainfrom Sep 29, 2025
Merged
Do not set OTel span error status for benign exceptions#530cretz merged 1 commit intotemporalio:mainfrom
cretz merged 1 commit intotemporalio:mainfrom
Conversation
THardy98
approved these changes
Sep 29, 2025
This was referenced Jan 14, 2026
Bump Temporalio.Extensions.DiagnosticSource from 1.9.0 to 1.10.0
InfinityFlowApp/aspire-temporal#267
Closed
This was referenced Feb 12, 2026
Bump Temporalio.Extensions.DiagnosticSource from 1.9.0 to 1.11.0
InfinityFlowApp/aspire-temporal#277
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Stop setting benign exceptions as OTel span errors (but still record exception)
Checklist