Fixed Temporalio.Bridge.Scope leaking cancellation tokens#547
Merged
maciejdudko merged 3 commits intotemporalio:mainfrom Oct 27, 2025
Merged
Fixed Temporalio.Bridge.Scope leaking cancellation tokens#547maciejdudko merged 3 commits intotemporalio:mainfrom
maciejdudko merged 3 commits intotemporalio:mainfrom
Conversation
cretz
reviewed
Oct 23, 2025
cretz
approved these changes
Oct 24, 2025
| return; | ||
| } | ||
|
|
||
| byteArrayRefs.Clear(); |
Member
There was a problem hiding this comment.
I don't think you need to clear these, but not a big deal
maciejdudko
force-pushed
the
bugfix-540
branch
from
6232809 to
cbbcba7
Compare
maciejdudko
force-pushed
the
bugfix-540
branch
from
cbbcba7 to
1bb7733
Compare
This was referenced Jan 14, 2026
Bump Temporalio.Extensions.DiagnosticSource from 1.9.0 to 1.10.0
InfinityFlowApp/aspire-temporal#267
Closed
This was referenced Feb 12, 2026
Bump Temporalio.Extensions.DiagnosticSource from 1.9.0 to 1.11.0
InfinityFlowApp/aspire-temporal#277
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Temporalio.Bridge.Scopeto correctly release both unmanaged (GCHandle) and managed (CancellationToken) resources.Temporalio.Bridge.CancellationTokennow unregisters its callback from the associatedSystem.Threading.CancellationTokenwhen freeing the handle.Why?
Fixes memory leak due to undisposed core-owned cancellation tokens.
Checklist
Closes [Bug] Memory Leak in Temporalio.Bridge.CancellationToken #540
How was this tested:
Automated testing is not possible for this bug. Manual testing was done following the "Minimal Reproduction" instructions in the linked issue.