Expose Workflow::allHandlersFinished()#486
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
wolfy-j
approved these changes
Aug 13, 2024
Sushisource
approved these changes
Aug 13, 2024
Member
Sushisource
left a comment
Sushisource
left a comment
There was a problem hiding this comment.
This makes good sense to me. We might at some point in the future want to provide a getAllRunningHandlers type of API that will return a list of things like handler name, etc, but I don't see anything here preventing us adding that later.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Added the new method
Workflow::allHandlersFinished()Added HandlerUnfinishedPolicy enum
Checklist