Use type in start/execute activity/workflow to address Pyright Strict mode error#1137
Merged
VegetarianOrc merged 5 commits intomainfrom Oct 2, 2025
Merged
Use type in start/execute activity/workflow to address Pyright Strict mode error#1137VegetarianOrc merged 5 commits intomainfrom
type in start/execute activity/workflow to address Pyright Strict mode error#1137VegetarianOrc merged 5 commits intomainfrom
Conversation
… with strict mode enabled
VegetarianOrc
force-pushed
the
bug/fix-pyright-partial-unknown
branch
from
8d46d6e to
4ec4889
Compare
tconley1428
approved these changes
Oct 1, 2025
… still solving the linting error
VegetarianOrc
changed the title
type in start/execute activity/workflow to address Pyright Strict mode error
cretz
reviewed
Oct 1, 2025
temporalio/client.py
Outdated
| id: str, | ||
| task_queue: str, | ||
| result_type: Optional[Type] = None, | ||
| result_type: Optional[Any] = None, |
Contributor
There was a problem hiding this comment.
Can this one (and the concrete impl's signature) be left as type too instead of changing to Any?
Contributor
Author
There was a problem hiding this comment.
Definitely, not sure how I missed those the first go around 😅
cretz
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Use
typeinstead ofTypeinstart_activity,execute_activity,start_workflow, andexecute_workflowWhy?
The overloads that allow for a result type to optionally be passed were causing the pyright linter to evaluate the result type to unknown when not specified.
Checklist
Closes [Bug] Pyright (strict mode) fails on
start/executeactivity/workflow calls #893 Closes [Bug] Pyright typing issue #795How was this tested:
Any docs updates needed?