Merged
Conversation
…rics test to properly assert both counter updates
…ith time skipping
tconley1428
reviewed
Dec 8, 2025
| nexus_context: _OperationCtxT | ||
| """Nexus-specific start operation context.""" | ||
|
|
||
| runtime_metric_meter: temporalio.common.MetricMeter |
Contributor
There was a problem hiding this comment.
This seems easy to mess up to me. If I'm just looking at the context, it seems easy to grab this one
Contributor
Author
There was a problem hiding this comment.
I went ahead and changed it from runtime_metric_meter to _runtime_metric_meter to help guide toward using metric_meter
tconley1428
approved these changes
Dec 8, 2025
Contributor
tconley1428
left a comment
tconley1428
left a comment
There was a problem hiding this comment.
Call out in the description what the breaking portion is.
…time_metric_meter private to help avoid confusion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
MetricMeterinside Nexus operation handlers.concurrent.futures.Executortoconcurrent.futures.ThreadPoolExecutor. This is a breaking change.Why?
To enable users to create metrics in Nexus operations in the same way as Activities.
The type of executor was narrowed to prevent users from running into known issues around pickleability. Additionally, handling Nexus operation start/cancel requests are intended to be short and aren't a great fit for something like a
ProcessPoolExecutor.Checklist
How was this tested:
New tests were added to include execution of Nexus operations via the async event loop and a
ThreadPoolExecutorand verify that metrics are sent. The new tests mirror the existing workflow metrics tests, but are skipped in the time skipping environment due to lack of Nexus support.