Standalone Activity List and Count ActivityExecutions by dandavison · Pull Request #8789 · temporalio/temporal

dandavison · 2025-12-10T02:02:42Z

Implement standalone activity ListActivityExecutions and CountActivityExecutions.

Note

Introduce List/Count ActivityExecutions for standalone activities with queryable search attributes and supporting validation/mapping.

Frontend:
- Implement ListActivityExecutions and CountActivityExecutions using chasm.ListExecutions/CountExecutions; build ActivityExecutionListInfo and grouped counts; paging support.
- Refactor start-request validation into frontendHandler.validateAndPopulateStartRequest and validateAndNormalizeStartActivityExecutionRequest; add SA unaliasing/validation.
Activity Component:
- Add visibility SAs (ActivityType, ActivityStatus, ActivityTaskQueue) and implement VisibilitySearchAttributesProvider via SearchAttributes.
- Extract InternalStatusToAPIStatus and run-state mapping; use in buildActivityExecutionInfo.
Library/Registration:
- Register component with declared search attributes in library.go.
Visibility Query Resolution:
- Map ActivityId → WorkflowId as a fallback in resolver; add ActivityID constant in sadefs/constants.go.
Tests:
- Add comprehensive tests for listing, counting (including grouping and custom SAs), and helpers; update validator tests to new validation entry points.

^{Written by Cursor Bugbot for commit 74c4fa6. This will update automatically on new commits. Configure here.}

chasm/lib/activity/activity.go

bergundy · 2025-12-11T20:32:49Z

chasm/lib/activity/activity.go

+const (
+	ActivityTypeSAAlias      = "ActivityType"
+	ActivityStatusSAAlias    = "ActivityStatus"
+	ActivityTaskQueueSAAlias = "ActivityTaskQueue"


Suggested change

ActivityTaskQueueSAAlias = "ActivityTaskQueue"

TaskQueueSAAlias = "TaskQueue"

Same here, it's just task queue.

Discussed offline, we decided to keep this as-is for now. Other work will address.

bergundy · 2025-12-11T20:33:51Z

chasm/lib/activity/activity.go

 	"google.golang.org/protobuf/types/known/durationpb"
 	"google.golang.org/protobuf/types/known/timestamppb"
 )

+const (
+	ActivityTypeSAAlias      = "ActivityType"
+	ActivityStatusSAAlias    = "ActivityStatus"


Suggested change

ActivityStatusSAAlias = "ActivityStatus"

ActivityStatusSAAlias = "ExecutionStatus"

Use the same non-qualified name as workflows.

Should I also ignore this comment and leave it as-is, as we have done for "ActivityTaskQueue"?

I've left this as "ActivityStatus" for now, pending advice (I know there were some discussions in progress relevant to this).

bergundy · 2025-12-11T20:35:43Z

chasm/lib/activity/activity.go

+	ActivityTypeSearchAttribute      = chasm.NewSearchAttributeKeyword(ActivityTypeSAAlias, chasm.SearchAttributeFieldKeyword01)
+	ActivityStatusSearchAttribute    = chasm.NewSearchAttributeKeyword(ActivityStatusSAAlias, chasm.SearchAttributeFieldLowCardinalityKeyword01)
+	ActivityTaskQueueSearchAttribute = chasm.NewSearchAttributeKeyword(ActivityTaskQueueSAAlias, chasm.SearchAttributeFieldKeyword02)


I would be totally okay if we didn't stutter here and omitted the Activity prefix from these variables. We're already in the activity package.

bergundy · 2025-12-11T20:36:49Z

chasm/lib/activity/frontend.go

+	if err != nil {
+		return nil, err
+	}
+	ctx = chasm.NewVisibilityManagerContext(ctx, h.visibilityManager)


This is something that we expect to be done in an interceptor. Please coordinate with @awln-temporal @lina-temporal and @rodrigozhou on this.

Is this blocking?

OK I see the interceptor was added on main. I've rebased standalone-activity on main and rebased this PR on standalone-activity and got rid of this.

bergundy · 2025-12-11T20:39:51Z

chasm/lib/activity/frontend.go

@@ -238,6 +325,21 @@ func (h *frontendHandler) validateAndPopulateStartRequest(
 	}
 	applyActivityOptionsToStartRequest(opts, req)

+	// TODO: Unalias for validation, then restore aliased SA for CHASM visibility storage. The
+	// validator requires unaliased format but CHASM visibility expects aliased format.
+	originalSA := req.SearchAttributes


I would make validateAndNormalizeStartActivityExecutionRequest a method of the handler and unalias in there. Seems cleaner than mutating the request twice.

bergundy · 2025-12-11T20:42:40Z

common/persistence/visibility/store/query/resolve.go

@@ -38,6 +38,12 @@ func ResolveSearchAttributeAlias(
 			return sadefs.WorkflowID, saType, nil
 		}

+		// Handle ActivityId → WorkflowID transformation for standalone activities


Visibility team should fix the need to hardcode here eventually. Add a TODO.

bergundy · 2025-12-11T20:50:54Z

common/searchattribute/sadefs/constants.go

@@ -59,6 +59,8 @@ const (
 	// any other custom search attribute.
 	ScheduleID = "ScheduleId"

+	ActivityId = "ActivityId"


Same here, add a TODO to remove this hardcoded constant.

bergundy · 2025-12-11T20:52:23Z

tests/standalone_activity_test.go

+		customSAName := "ActivityCustomKeyword"
+		customSAValue := "custom-sa-test-value"
+
+		_, err := s.OperatorClient().AddSearchAttributes(ctx, &operatorservice.AddSearchAttributesRequest{


I think there's a set of custom search attributes already defined for all functional tests.

Thanks, using the predefined custom SAs

bergundy · 2025-12-11T20:55:06Z

tests/standalone_activity_test.go

+	})
+
+	t.Run("QueryByActivityStatus", func(t *testing.T) {
+		verifyListQuery(t, fmt.Sprintf("ActivityStatus = 'Scheduled' AND ActivityType = '%s'", activityType))


What's Scheduled? It's supposed Running as we have for ExecutionStatus for workflows (case sensitive?)

Thanks, fixed

bergundy · 2025-12-11T20:58:35Z

tests/standalone_activity_test.go

+		s.Equal(activityID, exec.GetActivityId())
+		s.Equal(runID, exec.GetRunId())
+		s.Equal(activityType, exec.GetActivityType().GetName())
+		s.Equal(enumspb.ACTIVITY_EXECUTION_STATUS_RUNNING, exec.GetStatus())
+		s.NotNil(exec.GetScheduleTime())


Make sure you cover all of the fields of ActivityExecutionListInfo in this test.

All the fields are tested

chasm/lib/activity/frontend.go

chasm/lib/activity/activity.go

common/persistence/visibility/store/query/resolve.go

#8789 (comment) #8789 (comment)

#8789 (comment)

chasm/lib/activity/frontend.go

#8789 (comment) #8789 (comment)

#8789 (comment)

awln-temporal · 2025-12-17T17:49:05Z

chasm/lib/activity/frontend.go

 }

+// validateAndNormalizeStartActivityExecutionRequest validates and normalizes the standalone
+// activity specific attributes. Note that this method mutates the input params; the caller must


nit: differentiate standalone activity "chasm" search attributes vs user defined custom search attributes.

awln-temporal · 2025-12-17T17:50:35Z

common/persistence/visibility/store/query/resolve.go


+		// Handle ActivityId → WorkflowID transformation for standalone activities.
+		// TODO: Remove this hardcoded transformation.
+		if name == sadefs.ActivityID {


Depending on which PR gets landed first, we'll need a follow up here to use the RegistrableComponent BusinessID option: #8803.

Thanks, added the PR to the TODO comment.

awln-temporal · 2025-12-17T18:00:32Z

chasm/lib/activity/validator.go

@@ -251,15 +206,26 @@ func validateInputSize(

 func validateAndNormalizeSearchAttributes(


this pattern will probably be common for most archetypes that support custom search attributes, might be worth moving to a common shared func in the chasm package, but not blocking.

Thanks, I added a note

Implement standalone activity ListActivityExecutions and CountActivityExecutions.

dandavison force-pushed the saa-visibility branch 2 times, most recently from 601fb05 to 65cb249 Compare December 11, 2025 02:21

dandavison changed the title ~~Standalone Activity ListActivityExecutions~~ Standalone Activity List and Count ActivityExecutions Dec 11, 2025

dandavison force-pushed the saa-visibility branch 2 times, most recently from e349308 to dbdead0 Compare December 11, 2025 20:26

dandavison marked this pull request as ready for review December 11, 2025 20:26

dandavison requested review from a team as code owners December 11, 2025 20:26

dandavison requested review from awln-temporal, bergundy and fretz12 December 11, 2025 20:26

cursor bot reviewed Dec 11, 2025

View reviewed changes

chasm/lib/activity/activity.go Show resolved Hide resolved

chasm/lib/activity/activity.go Outdated Show resolved Hide resolved

dandavison force-pushed the saa-visibility branch from c06d36b to 155925e Compare December 11, 2025 20:52

bergundy reviewed Dec 11, 2025

View reviewed changes

cursor bot reviewed Dec 11, 2025

View reviewed changes

chasm/lib/activity/frontend.go Outdated Show resolved Hide resolved

dandavison force-pushed the saa-visibility branch from 083b015 to 4f365ba Compare December 13, 2025 18:30

cursor bot reviewed Dec 13, 2025

View reviewed changes

chasm/lib/activity/activity.go Outdated Show resolved Hide resolved

cursor bot reviewed Dec 15, 2025

View reviewed changes

common/persistence/visibility/store/query/resolve.go Show resolved Hide resolved

dandavison added a commit that referenced this pull request Dec 16, 2025

Add TODO comments for hardcoded ActivityId constant

ee404b3

#8789 (comment) #8789 (comment)

dandavison added a commit that referenced this pull request Dec 16, 2025

Fix CloseTime incorrectly set to Unix epoch for running activities

7e99162

#8789 (comment) #8789 (comment)

dandavison added a commit that referenced this pull request Dec 16, 2025

Store API status in ActivityStatus search attribute

4016188

#8789 (comment) #8789 (comment)

dandavison added a commit that referenced this pull request Dec 16, 2025

Move SA unalias logic into validation method

f69f1d9

#8789 (comment)

dandavison force-pushed the saa-visibility branch from e843c8e to 6f04ad6 Compare December 16, 2025 02:02

cursor bot reviewed Dec 16, 2025

View reviewed changes

chasm/lib/activity/frontend.go Show resolved Hide resolved

dandavison added 6 commits December 15, 2025 22:09

Implement ListActivityExecutions and CountActivityExecutions

4ef4520

Cleanup

b083b1c

Eliminate stuttering in variable names

b2b7ab0

Add TODO comments for hardcoded ActivityId constant

f8b7057

#8789 (comment) #8789 (comment)

Fix CloseTime incorrectly set to Unix epoch for running activities

aeb6fa8

#8789 (comment) #8789 (comment)

Store API status in ActivityStatus search attribute

c041c8b

#8789 (comment) #8789 (comment)

dandavison added a commit that referenced this pull request Dec 16, 2025

Move SA unalias logic into validation method

611e0a1

#8789 (comment)

dandavison force-pushed the saa-visibility branch 3 times, most recently from afa1675 to 973dc71 Compare December 16, 2025 03:29

dandavison requested a review from bergundy December 16, 2025 03:33

dandavison added 8 commits December 16, 2025 09:23

Move SA unalias logic into validation method

e95c856

#8789 (comment)

Remove redundant CHASM interceptor that has been added in main

0ef4ad2

Remove unecessary Memo

e1ceba7

Add missing config.enabled check

450d1e0

Use SAs pre-defined for functional tests

ff225f6

Test returned SAs

98db00a

return custom SAs

9024624

Cleanup

8f2aa3d

dandavison force-pushed the saa-visibility branch from 21c8277 to 8f2aa3d Compare December 16, 2025 14:24

Lint fixes

74c4fa6

awln-temporal approved these changes Dec 17, 2025

View reviewed changes

awln-temporal reviewed Dec 17, 2025

View reviewed changes

dandavison merged commit 0247cf0 into standalone-activity Dec 17, 2025
92 of 98 checks passed

dandavison deleted the saa-visibility branch December 17, 2025 19:31

dandavison added a commit that referenced this pull request Dec 19, 2025

Standalone Activity List and Count ActivityExecutions (#8789)

a4d5b49

Implement standalone activity ListActivityExecutions and CountActivityExecutions.

	ActivityTaskQueueSAAlias = "ActivityTaskQueue"
	TaskQueueSAAlias = "TaskQueue"

	ActivityStatusSAAlias = "ActivityStatus"
	ActivityStatusSAAlias = "ExecutionStatus"

		@@ -251,15 +206,26 @@ func validateInputSize(

		func validateAndNormalizeSearchAttributes(

Conversation

dandavison commented Dec 10, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dandavison commented Dec 10, 2025 •

edited by cursor bot

Loading