Standalone activity: clean up outcome computation#8872
Merged
dandavison merged 1 commit intostandalone-activityfrom Dec 18, 2025
Merged
Standalone activity: clean up outcome computation#8872dandavison merged 1 commit intostandalone-activityfrom
dandavison merged 1 commit intostandalone-activityfrom
Conversation
fretz12
approved these changes
Dec 18, 2025
dandavison
added a commit
that referenced
this pull request
Dec 19, 2025
## What changed? Cleaner implementation of logic involved when obtaining activity outcome for `DescribeActivityExecution` and `PollActivityExecution`. ## Why? Code cleanup. Suggested at #8771 (comment) ## How did you test it? - [x] built - [x] covered by existing tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Cleaner implementation of logic involved when obtaining activity outcome for
DescribeActivityExecutionandPollActivityExecution.Why?
Code cleanup. Suggested at #8771 (comment)
How did you test it?
Note
Streamlines
outcometo return nil unless closed and consolidates failure resolution using last attempt details.chasm/lib/activity/activity.go):outcometo returnnilunless lifecycle is closed.Outcome.Successful/Outcome.Failed; otherwise fall back toLastAttempt.LastFailureDetails(removes status-based checks).Written by Cursor Bugbot for commit 6674ea5. This will update automatically on new commits. Configure here.