d2ir: fix glob edge with common glob#1713
Merged
alixander merged 1 commit intoterrastruct:masterfrom Nov 10, 2023
Merged
Conversation
alixander
force-pushed
the
connections-glob
branch
from
041041b to
87736b1
Compare
|
Thanks for the quick fix. I'm already eager to play around with this :D |
|
@alixander I just built this from source. Your fix works for me and seems to cover all my current use cases. However, it seems to not fix globs in general. For example |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1712
before it was creating nodes unnecessarily