Skip to content

customize theme colors in d2-config#1777

Merged
alixander merged 4 commits intoterrastruct:masterfrom
alixander:customize-themes
Dec 14, 2023
Merged

customize theme colors in d2-config#1777
alixander merged 4 commits intoterrastruct:masterfrom
alixander:customize-themes

Conversation

@alixander
Copy link
Collaborator

Screen Shot 2023-12-13 at 12 17 57 PM

closes #1487

@alixander alixander requested a review from gavin-ts December 13, 2023 20:18
@alixander alixander changed the title customize theme colors in vars-config customize theme colors in d2-config Dec 13, 2023
@alixander alixander force-pushed the customize-themes branch 3 times, most recently from 27da0cb to f43bfda Compare December 13, 2023 20:30
@gavin-ts
Copy link
Contributor

gavin-ts commented Dec 13, 2023

looks good but I'm not sure why this doesn't seem to work with go build . && ./d2 test.d2 I was trying to test the color validation that shows this message when running the e2e test with an invalid color (B4: not a color) e2e_test.go:258: unexpected error: Invalid color format, not a color, but it compiles without error and without the overrides applying

@alixander
Copy link
Collaborator Author

@gavin-ts good call, added validation

@alixander alixander requested a review from gavin-ts December 14, 2023 21:08
@alixander alixander merged commit 37bd766 into terrastruct:master Dec 14, 2023
@alixander alixander deleted the customize-themes branch December 14, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

customize theme colors with d2-config var

2 participants

Comments