Use portable-atomic on platforms without u64 atomics#148
Open
linkmauve wants to merge 1 commit intotesselode:mainfrom
Open
Use portable-atomic on platforms without u64 atomics#148linkmauve wants to merge 1 commit intotesselode:mainfrom
linkmauve wants to merge 1 commit intotesselode:mainfrom
Conversation
96aa32e to
43a4f5b
Compare
This has been tested on powerpc-unknown-linux-gnu, which supports
atomics only up to u32. Without this commit, building kira would fail
with:
error[E0432]: unresolved import `std::sync::atomic::AtomicU64`
--> crates/kira/src/backend/cpal/desktop/stream_manager.rs:6:24
|
6 | atomic::{AtomicBool, AtomicU64, Ordering},
| ^^^^^^^^^
| |
| no `AtomicU64` in `sync::atomic`
| help: a similar name exists in the module: `AtomicU32`
43a4f5b to
9b6f194
Compare
Author
|
I just rebased that PR on top of latest main, nothing much was changed but there was a merge conflict. |
Owner
|
Which test isn't passing? I'm unclear on what this has to do with |
Author
|
This PR is the only one required to make |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been tested on
powerpc-unknown-linux-gnu, which supports atomics only up tou32. Without this commit, building kira would fail with:Edit: This also depends on not-fl3/quad-rand#23 in order to make the whole testsuite pass, but can be merged independently.