Handle no dictionary words during pass 1 word recognition (issue #4448)#4449
Open
sebras wants to merge 1 commit intotesseract-ocr:mainfrom
Open
Handle no dictionary words during pass 1 word recognition (issue #4448)#4449sebras wants to merge 1 commit intotesseract-ocr:mainfrom
sebras wants to merge 1 commit intotesseract-ocr:mainfrom
Conversation
Author
|
Please let me know if I made a mistake and help me rectify it. This is my first attempt at contributing to Tesseract. :) |
egorpugin
approved these changes
Aug 9, 2025
Contributor
egorpugin
left a comment
egorpugin
left a comment
There was a problem hiding this comment.
Just ->best_choice && ... is ok.
…eract-ocr#4448) Previously if page_res_it.word()->best_choice == nullptr, dereferencing it in page_res_it.word()->best_choice->permuter() caused a segmentation fault. By checking best_choice != nullptr, i.e. there is a dictionary word, before dereferencing it, the crash is avoided. Signed-off-by: Sebastian Rasmussen <sebras@gmail.com>
Author
Aha! I'm not well versed in C++, so I just looked at nearby code and used their NULL-checks. I'll fix it in a jiffy. :) |
Collaborator
|
See my comments in issue #4448. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously if page_res_it.word()->best_choice == nullptr, dereferencing it in page_res_it.word()->best_choice->permuter() caused a segmentation fault.
By checking best_choice != nullptr, i.e. there is a dictionary word, before dereferencing it, the crash is avoided.