Make Bolt log wait strategy more lenient#4455
Merged
kiview merged 1 commit intotestcontainers:masterfrom Oct 22, 2021
Merged
Conversation
Contributor
Author
|
I could not find a simple way to write a test around the updated log strategy. I'm open to suggestions. |
Member
|
Hi @fbiville, I am just wondering - since we're already checking for 200 answer from the API, does it make sense to check for logs in addition to it? |
Contributor
Author
|
The 200 check is only for the HTTP server (https://neo4j.com/docs/http-api/current/), the other check is for the Bolt protocol (https://7687.org) server which serves another purpose. |
Member
|
And both servers can become ready independent of each other? |
Contributor
Author
Sorry for the late reply. Indeed, there is no relation between the two. One server being ready does not mean the other is and vice-versa. |
bsideup
approved these changes
Oct 22, 2021
rnorth
approved these changes
Oct 22, 2021
kiview
approved these changes
Oct 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4454