Switch toxiproxy default image to ghcr.io and update default tag to 2.4.0#5173
Merged
eddumelendez merged 3 commits intotestcontainers:masterfrom Jun 28, 2022
Merged
Switch toxiproxy default image to ghcr.io and update default tag to 2.4.0#5173eddumelendez merged 3 commits intotestcontainers:masterfrom
eddumelendez merged 3 commits intotestcontainers:masterfrom
Conversation
gmunozfe
changed the title
Contributor
|
@gmunozfe 2.4.0 is the latest version. Maybe makes sense to use it instead of 2.3.0? |
gmunozfe
changed the title
Contributor
Author
|
@Aloren sure, updated with the last one, thanks for pointing out |
Contributor
Author
|
hi, any update on this? |
eddumelendez
requested changes
Jun 16, 2022
Member
eddumelendez
left a comment
eddumelendez
left a comment
There was a problem hiding this comment.
thanks for your contribution @gmunozfe ! I have added a suggestion, after that I would be glad to merge it.
|
|
||
| private static final DockerImageName DEFAULT_IMAGE_NAME = DockerImageName.parse("shopify/toxiproxy"); | ||
| private static final String DEFAULT_TAG = "2.1.0"; | ||
| private static final DockerImageName DEFAULT_IMAGE_NAME = DockerImageName.parse("ghcr.io/shopify/toxiproxy"); |
Member
There was a problem hiding this comment.
we need to keep backward compatibility, in this case I would suggest to add a new image name
private static final DockerImageName GHCR_IMAGE_NAME = DockerImageName.parse("ghcr.io/shopify/toxiproxy");and add it here
dockerImageName.assertCompatibleWith(DEFAULT_IMAGE_NAME, GHCR_IMAGE_NAME);
eddumelendez
approved these changes
Jun 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toxiproxy is no longer updating their images in dockerhub but in ghcr.
Updated DEFAULT_IMAGE_NAME to "ghcr.io/shopify/toxiproxy" and DEFAULT_TAG to "2.4.0". Notice that "toxiproxy-java" library 2.1.5 (the one included in testcontainers module) is compatible with 2.4.0.