Test DOCKER_HOST in DockerClientProviderStrategy#5357
Merged
Conversation
eddumelendez
approved these changes
May 9, 2022
kiview
approved these changes
May 9, 2022
Member
kiview
left a comment
kiview
left a comment
There was a problem hiding this comment.
Made some smaller suggestions, feel free to include them as you see fit.
core/src/main/java/org/testcontainers/dockerclient/DockerClientProviderStrategy.java
Show resolved
Hide resolved
core/src/main/java/org/testcontainers/dockerclient/DockerClientProviderStrategy.java
Show resolved
Hide resolved
core/src/main/java/org/testcontainers/dockerclient/DockerClientProviderStrategy.java
Show resolved
Hide resolved
core/src/main/java/org/testcontainers/dockerclient/DockerClientProviderStrategy.java
Show resolved
Hide resolved
kiview
approved these changes
May 9, 2022
core/src/main/java/org/testcontainers/dockerclient/DockerClientProviderStrategy.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make invalidating stale Docker client strategies faster, this PR introduces a synthetic check performed in
DockerClientProviderStrategy.Should also help with #5174 where Docker is listening but takes time to respond (the client timeout now applies to the Socket check, not
/infocommand)